Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Temporarily mark upstream TabInterface pointer as DanglingUntriaged
Our sidebar pinning service detaches (but does not delete) tabs and caches their WebContents under certain circumstances. This has the unwanted side effect of creating a dangling pointer in the upstream code that manages the embedded tab interfaces. For now, we will mark this upstream pointer as DanglingUntriaged and we have opened brave/brave-browser#42322 to track this issue. Chromium change: https://source.chromium.org/chromium/chromium/src/+/bf1f8e50ede83c982c28e7e4254bad871b0c6bf7 commit bf1f8e50ede83c982c28e7e4254bad871b0c6bf7 Author: Thomas Lukaszewicz <[email protected]> Date: Wed Nov 6 19:37:01 2024 +0000 [webui] Use SetTabInterface for setting embedding context on tabs This CL updates webui::InitEmbeddingContext() to leverage the new SetTabInterface API. This allows correct handling of both tab and browser interfaces for tabs (vs only browser interfaces for the current impl). This CL also ensures discard is handled correctly. This handling can be removed once the new tab discarding has successfully landed. Bug: 360724768
- Loading branch information