Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QSE keyboard behaviour change #26549

Merged
merged 4 commits into from
Nov 15, 2024
Merged

QSE keyboard behaviour change #26549

merged 4 commits into from
Nov 15, 2024
+62 −12

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Nov 14, 2024 •
edited
Loading

Resolves brave/brave-browser#42186

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 14, 2024
@deeppandya deeppandya added this to the 1.75.x - Nightly milestone Nov 14, 2024
@deeppandya deeppandya self-assigned this Nov 14, 2024
@deeppandya deeppandya requested a review from a team as a code owner November 14, 2024 12:22
samartnik
samartnik reviewed Nov 14, 2024
View reviewed changes
...java/org/chromium/chrome/browser/quick_search_engines/utils/QuickSearchEnginesViewsUtil.java Outdated

public class QuickSearchEnginesViewsUtil {

// private static View mQuickSearchEnginesView;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to be all commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops i missed it. I am removing it right away

AlexeyBarabash
AlexeyBarabash approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

samartnik
samartnik approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SergeyZhukovsky
SergeyZhukovsky approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

bridiver
bridiver approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sources.gni ok

@deeppandya deeppandya merged commit ce151e7 into master Nov 15, 2024
17 checks passed
@deeppandya deeppandya deleted the qse_keyboard_behaviour_change branch November 15, 2024 22:10
@brave-builds
Copy link
Collaborator

Released in v1.75.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@bridiver bridiver bridiver approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.75.x - Nightly
Development

Successfully merging this pull request may close these issues.

Quick search taking space what i typed in Facebook comment input field
6 participants
@deeppandya @brave-builds @bridiver @SergeyZhukovsky @AlexeyBarabash @samartnik