Fixes cookie issues on login https://eple.sanity.studio/desk #8322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed, login now works correctly with CI Builds with the above patch cc: @pes10k
|
|
Thanks both! Just a heads up that @bridiver is working on a tweak to ES that should help further reduce the number of storage exceptions needed |
|
Solving an quite an old ticket, should I close this @bridiver or are the improvements to ES coming soon-ish? |
|
Re-checked this in the latest Nightly with ES enabled, still failing to get past the login . Safe to merge @bridiver ? |
|
Closing, a bit out date. can be re-reviewed when we've trimmed other cookie exceptions. |
kylehickinson
pushed a commit
that referenced
this pull request
Jan 4, 2024
Co-authored-by: Jacob Sikorski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#6099
Both domains are owned by the same company, seems
sanity.iois used as a cookie check forsanity.studioTested in Brave Beta + Enable Ephemeral Storage enabled. Still unable to login without allowing cookies for this site