New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump uniffi to 0.25.0 #925

Draft

ok300 wants to merge 4 commits into main from ok300-bump-uniffi

Contributor

ok300 commented Apr 12, 2024

This PR bumps our uniffi dependency from 0.23 to 0.25.

Changelog: https://github.com/mozilla/uniffi-rs/blob/main/CHANGELOG.md#v0250-backend-crates-v0250---2023-10-18

It also bumps

the NordSecurity uniffi-bindgen-go dependency
the Kotlin MPP https://gitlab.com/trixnity/uniffi-kotlin-multiplatform-bindings dependency

ok300 added 4 commits

April 12, 2024 14:06


          Consolidate uniffi version management

9591f3f


          Remove uniffi_build, uniffi_macros dependencies

e3bb0d1


          Bump uniffi, incl. kotlin mpp and go variants, to 0.25

8037d21


          Cargo fmt

a8fcef7

ok300 requested a review from dangeross

April 12, 2024 16:47

Collaborator

dangeross commented May 17, 2024

This is definitely possible, but I think it requires further rework

The macOS/iOS target dependencies need bumping to v15/v13. Probably has downstream effects on RN, Flutter and c-breez
Possible java/kotlin JNI dependency changes needed (for sure when moving to 0.27)
The uniffi-bindgen-go output has changed (.go/.c/.h files) and needs handling accordingly
The uniffi-bindgen-cs can also be updated, moving the repo back to NordSecurity and using v0.8.0+v0.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet