Add support for pending send #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
changed the title
hydra-yse
force-pushed
the
yse-pending-send
branch
from
e5100fb
to
2c4813a
Compare
ok300
reviewed
Mar 23, 2024
hydra-yse
force-pushed
the
yse-pending-send
branch
from
2c4813a
to
a853ac8
Compare
hydra-yse
commented
Mar 26, 2024
Comment on lines
+103
to
+122
| pub(crate) enum OngoingSwap { | ||
| Send { | ||
| id: String, | ||
| amount_sat: u64, | ||
| funding_address: String, | ||
| }, | ||
| Receive { | ||
| id: String, | ||
| preimage: String, | ||
| redeem_script: String, | ||
| blinding_key: String, | ||
| invoice_amount_sat: u64, | ||
| onchain_amount_sat: u64, | ||
| }, |
There was a problem hiding this comment.
Think I found the best of both worlds here; the tables are split but we can still represent methods uniquely. What do you think @ok300 ?
ok300
approved these changes
Mar 26, 2024
hydra-yse
force-pushed
the
yse-pending-send
branch
from
e866c3b
to
56dfb7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
OngoingSwapfor pending sends, giving the user the ability to list and filter them