Consolidate reverse swap amounts calculation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
approved these changes
Mar 25, 2024
ok300
force-pushed
the
ok300-simplify-get-chain
branch
from
938571d
to
709b045
Compare
ok300
force-pushed
the
ok300-simplify-rev-swap-amounts-calculations
branch
from
6add85a
to
2b65fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the amount and fee calculation logic for the reverse swap (
receive-payment) such that it's clearer how the amounts are calculated from the user input.Some PRs were opened in the Boltz client repo, which are needed for correct reverse fee calculation, i.e. if the user specifies the desired onchain amount. When they are merged, we can integrate them and update the places marked with TODOs in this PR.
Until then, the PR uses an approximation in the fee calculation for that case.