-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry chain swap server lockup tx verification #557
Conversation
lib/core/src/chain_swap.rs
Outdated
let claim_details = chain_swap.get_boltz_create_response()?.claim_details; | ||
let retries = if verify_confirmation { 30 } else { 0 }; | ||
let mut retry = 0; | ||
loop { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern here is that it will block the event status polling loop and may block other payment statuses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would take a only couple of attempts to get the confirmation, it testing it was confirmed in the first request. Maybe it's better to add it to the tracking thread to verify and claim if needed
e9afbd1
to
18a6427
Compare
18a6427
to
1ba233d
Compare
I was able to catch a failed confirmation and see it picked up in the monitoring thread
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR retries adds monitoring of the incoming server lockup txs. If a server lockup tx is confirmed without a claim (tx failed verification when receiving the Boltz status), then perform the claim.
Fixes #547