-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional filter level param to set log stream #23
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to change the implementation in the native generators
Kotlin:
fun setLogStream(promise: Promise) { |
Swift:
setLogStream: (RCTPromiseResolveBlock)resolve |
breez-sdk-rn-generator/src/gen_swift/templates/module.swift
Lines 75 to 76 in 59b4ba2
@objc(setLogStream:reject:) | |
func setLogStream(_ resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void { |
d6aeb17
to
7ff53bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please bump the Cargo.toml version
Bumped 👍 430a73a |
setLogStream
andconnect
aren't generated in the same way as the other methods and needs to be updated manually.Changes required for:
env_logger
module filters on Dart & UniFFI binding loggers breez-sdk-greenlight#874