Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional filter level param to set log stream #23

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

erdemyerebasmaz
Copy link

setLogStream and connect aren't generated in the same way as the other methods and needs to be updated manually.

Changes required for:

Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to change the implementation in the native generators

Kotlin:

fun setLogStream(promise: Promise) {

Swift:

setLogStream: (RCTPromiseResolveBlock)resolve

@objc(setLogStream:reject:)
func setLogStream(_ resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {

src/gen_swift/templates/module.swift Outdated Show resolved Hide resolved
src/gen_swift/templates/module.swift Outdated Show resolved Hide resolved
src/gen_swift/templates/module.swift Outdated Show resolved Hide resolved
src/gen_kotlin/templates/module.kt Outdated Show resolved Hide resolved
src/gen_kotlin/templates/module.kt Outdated Show resolved Hide resolved
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please bump the Cargo.toml version

@erdemyerebasmaz
Copy link
Author

erdemyerebasmaz commented Mar 25, 2024

Looks good, but please bump the Cargo.toml version

Bumped 👍 430a73a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants