Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflows #11

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Add CI workflows #11

merged 4 commits into from
Jun 4, 2024

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Jun 3, 2024

This PR adds CI workflows to

  • validate PRs that are being merged to main
  • build an Android APK
  • publish app to TestFlight

TODO:

  • Add secrets to repo
  • Create a development provisioning profile for l-breez
  • Add l-breez to TestFlight (Requires admin privileges - @roeierez)

@erdemyerebasmaz erdemyerebasmaz linked an issue Jun 3, 2024 that may be closed by this pull request
3 tasks
@erdemyerebasmaz erdemyerebasmaz force-pushed the ci_workflows branch 4 times, most recently from 1a65961 to 0c4b9b3 Compare June 4, 2024 09:57
@erdemyerebasmaz
Copy link
Collaborator Author

Create a development provisioning profile for l-breez
Add l-breez to TestFlight (Requires admin privileges - @roeierez)

TODO items related to iOS build will be handled in the future and is outside the scope of this PR.

@erdemyerebasmaz erdemyerebasmaz linked an issue Jun 4, 2024 that may be closed by this pull request
@erdemyerebasmaz erdemyerebasmaz linked an issue Jun 4, 2024 that may be closed by this pull request
repository: 'breez/breez-sdk'
ssh-key: ${{secrets.REPO_SSH_KEY}}
path: 'breez-sdk'
ref: 'fca80043d011f213741ddae93973ed264a8b6ddb'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth adding this as a breez_sdk_ref input? Maybe a specific branch would be better

.github/workflows/build-android.yml Outdated Show resolved Hide resolved
.github/workflows/build-ios.yml Outdated Show resolved Hide resolved
.github/workflows/build-ios.yml Outdated Show resolved Hide resolved
* Upgrade to checkout@v4
* Upgrade to setup-java@v2
* Changer runner to macOS-latest
* Fix linter warning
* Allow setting Liquid & Breez SDK ref on manually triggered workflows
* Address feedback
@erdemyerebasmaz erdemyerebasmaz merged commit 5049caa into main Jun 4, 2024
1 check failed
@erdemyerebasmaz erdemyerebasmaz deleted the ci_workflows branch June 4, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate CI checks for PRs
2 participants