Fix: App fails to resume on update #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
changed the base branch from
main
to
enter_payment_info_fullscreen
erdemyerebasmaz
force-pushed
the
enter_payment_info_fullscreen
branch
from
21eaa16
to
4afd630
Compare
erdemyerebasmaz
force-pushed
the
resume-on-update-hydrated-bloc
branch
from
2a2e317
to
72938d2
Compare
erdemyerebasmaz
force-pushed
the
resume-on-update-hydrated-bloc
branch
3 times, most recently
from
7692c17
to
cff6106
Compare
erdemyerebasmaz
force-pushed
the
enter_payment_info_fullscreen
branch
from
82df0b3
to
ce25c1b
Compare
* Use GetInfoResponse directly on AccountState * Rename initial to isInitial * Save BigInt's as string * Set isInitial default value to true * Add toJson fromJson extensions to GetInfoResponse * Add null handling to AccountState.fromJson
* Rename isInitial to isOnboardingComplete * Remove unused registrationRequested param from UserProfileCubit updateProfile fn. * Make sdkConnectivityCubit final
Set minimum deployment target on iOS to 15.6
erdemyerebasmaz
force-pushed
the
resume-on-update-hydrated-bloc
branch
from
cff6106
to
fb26408
Compare
erdemyerebasmaz
added a commit
that referenced
this pull request
Nov 6, 2024
… page (#223) * Fix: App fails to resume on update (#222) * fix: Create artifacts with iOS build * Simplify AccountState * Use GetInfoResponse directly on AccountState * Rename initial to isInitial * Save BigInt's as string * Set isInitial default value to true * Add toJson fromJson extensions to GetInfoResponse * Add null handling to AccountState.fromJson * Check if onboarding is complete before attempting to reconnect * Rename isInitial to isOnboardingComplete * Remove unused registrationRequested param from UserProfileCubit updateProfile fn. * Make sdkConnectivityCubit final * Eagerly load AccountCubit * Prevent duplicate Firebase initialization if an app instance already exists * Initialize Firebase with project ID * chore: melos pub-upgrade * Update cocoapods and reinstall pods * chore: update dependencies to latest Set minimum deployment target on iOS to 15.6 * Track newly received payments on LN Address page * Stay on "Receive via Lightning Address" page when new payments are received * Do not show "Payment failed" flushbar on "Receive via Lightning Address" page * Show successful payment route once for each payment * Do not show it for the same payments both pending & completed status updates * Skip the first item on the stream * Do not cancel stream subscription if payment fails on LN Address page * Fix payment tracking for lightning invoices & swaps * Remove the 1 second delay before showing successful payment route * Clarify the comments * Refactor LNURL payment tracking * Do pre-filtering while listening the stream and change it's type to PaymentData? * Only process pending status of LNURL payments * Remove _processedPayments logic * Rename trackPayment fn to trackPaymentEvents Add logs to _trackNewPayments * Disable particles on successful payment route for payments received on LN Address page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
and includes several enchantments and fixes related to the iOS build process, account state management and Firebase initialization.
Changelist:
AccountCubitAccountState:GetInfoResponse?directly onAccountStateinstead of mapping it to individual fieldsinitialtoIsOnboardingCompleteand set it's default value tofalsefor clarityBigIntvalues as strings for better serialization.toJsonandfromJsonextensions toGetInfoResponsefor improved data handlingAccountState.fromJsonOther changelist:
sdkConnectivityCubitfinal to improve code safety.registrationRequestedparameter from theupdateProfilefunction inUserProfileCubit.