Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for initial sync to complete before showing wallet information #230

Merged
merged 8 commits into from
Nov 12, 2024
Merged

Wait for initial sync to complete before showing wallet information #230

merged 8 commits into from
Nov 12, 2024

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Nov 7, 2024 •
edited
Loading

Fixes #157

This PR improves the initial loading experience by managing wallet information loading and handling initial sync.

Changelist:

  • Display a loading animation until wallet information is available.
    • Show an animated "..." text on payment list while waiting for wallet information on fresh install/restores.
    • Show a sync icon while waiting for wallet information on app bar.
      • This icon is mostly visible on fresh install/restores, UI loads before the user has a chance to see it when their wallet is not far behind,
  • Hide balance until wallet information is available.
  • Hide slivers that display wallet information until wallet information is available.
  • Add didInitialSyncComplete stream to BreezSdkLiquid & notify the app layer when initial sync completes.
  • Pass payment list from AccountPage to PaymentsList widget
    • PaymentsList widget is not used elsewhere and there's no need to encapsulate state retrieval inside the widget itself
    • This is a negligible change in terms of performance.

@erdemyerebasmaz
Refactor Wallet Dashboard & it's widgets (#233)
65b0cce 
* Refactor WalletDashboard & it's widgets

* Display placeholder items while restoring (#234)

* Add restore state to AccountState

* Show placeholder balance & payment list when restoring

* Hide bubbles when restoring
@erdemyerebasmaz
Fix: Persist payment list (#232)
1be822d 
* fix: Persist payment list

* force update payment list upon receiving first sync event

* Fire `didCompleteInitialSync` event after wallet data is fetched
@erdemyerebasmaz erdemyerebasmaz merged commit 25f6e15 into main Nov 12, 2024
1 check passed
@erdemyerebasmaz erdemyerebasmaz deleted the initial_sync branch November 12, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeierez roeierez roeierez approved these changes

@dangeross dangeross Awaiting requested review from dangeross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Balance and history flashing wrong values
2 participants
@erdemyerebasmaz @roeierez