Handle LNURL's #38
Merged
Handle LNURL's #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
30b3138
to
4c59833
Compare
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
03be4ac
to
7a84aa4
Compare
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
7a84aa4
to
4d6bbaf
Compare
erdemyerebasmaz
force-pushed
the
dependencies
branch
2 times, most recently
from
dcf0a9f
to
58bc665
Compare
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
4d6bbaf
to
9d94453
Compare
roeierez
approved these changes
Jul 11, 2024
dangeross
reviewed
Jul 11, 2024
There was a problem hiding this comment.
I think it looks good.
Perhaps we need to use the newly added fetchLightningLimits() function to check the selected pay/withdraw amounts are within the send/receive swap limits. Or maybe combine the min/max sendable/withdrawable with the swap limits to get unified limits
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
2 times, most recently
from
e1d4c0b
to
f25afa2
Compare
Applied this on LnUrl payments, limits on withdraw flow will be applied on new UI due to an incompatibility. |
dangeross
reviewed
Jul 12, 2024
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
f25afa2
to
a67a108
Compare
* Validate LnUrl payments against lightning limits * Rename isLnurlPayment to isLnUrlPayment for consistency of capitalization of LnUrl
erdemyerebasmaz
force-pushed
the
handle_lnurls
branch
from
a67a108
to
266470e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
#30
LNURL-Pay, LNURL-Withdraw, LNURL-Auth are now handled on l-breez app.
Other changelist:
parseInputAPI is no longer a sync function