Bump version, global state fix + TODO notes

dcargs/_arguments.py

@@ -279,6 +279,8 @@ def as_str(x: Any) -> Tuple[str, ...]:
 
 # This can be turned off when we don't want rich-based formatting. (notably for
 # completion scripts)
+#
+# TODO: the global state here is gross. Should be revisited.
 USE_RICH = True
 
 

dcargs/_cli.py

@@ -205,16 +205,6 @@ def _cli_impl(
     else:
         dummy_wrapped = False
 
-    # Map a callable to the relevant CLI arguments + subparsers.
-    parser_definition = _parsers.ParserSpecification.from_callable_or_type(
-        f,
-        description=description,
-        parent_classes=set(),  # Used for recursive calls.
-        parent_type_from_typevar=None,  # Used for recursive calls.
-        default_instance=default_instance_internal,  # Overrides for default values.
-        prefix="",  # Used for recursive calls.
-    )
-
     # Read and fix arguments. If the user passes in --field_name instead of
     # --field-name, correct for them.
     args = sys.argv[1:] if args is None else args
@@ -237,6 +227,9 @@ def fix_arg(arg: str) -> str:
     # goal, but manual parsing of argv is convenient for turning off formatting.
     print_completion = len(args) >= 2 and args[0] == "--dcargs-print-completion"
 
+    # Note: setting USE_RICH must happen before the parser specification is generated.
+    # TODO: revisit this. Ideally we should be able to eliminate the global state
+    # changes.
     completion_shell = None
     if print_completion:
         completion_shell = args[1]
@@ -245,6 +238,16 @@ def fix_arg(arg: str) -> str:
     else:
         _arguments.USE_RICH = True
 
+    # Map a callable to the relevant CLI arguments + subparsers.
+    parser_definition = _parsers.ParserSpecification.from_callable_or_type(
+        f,
+        description=description,
+        parent_classes=set(),  # Used for recursive calls.
+        parent_type_from_typevar=None,  # Used for recursive calls.
+        default_instance=default_instance_internal,  # Overrides for default values.
+        prefix="",  # Used for recursive calls.
+    )
+
     # Generate parser!
     with _argparse_formatter.ansi_context():
         parser = argparse.ArgumentParser(

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "dcargs"
-version = "0.3.17"
+version = "0.3.18"
 description = "Strongly typed, zero-effort CLI interfaces"
 authors = ["brentyi <[email protected]>"]
 include = ["./dcargs/**/*"]