Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing.Annotated workaround for pydantic v1 #187

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Oct 24, 2024

Older versions of pydantic didn't support typing.Annotated, since typing.Annotated didn't exist yet. I added a workaround for this.

Fixes #186

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (b358dfa) to head (f857a9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #187   +/-   ##
=======================================
  Coverage   99.71%   99.72%           
=======================================
  Files          25       25           
  Lines        2142     2143    +1     
=======================================
+ Hits         2136     2137    +1     
  Misses          6        6           
Flag Coverage Δ
unittests 99.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit ea22883 into main Oct 24, 2024
15 checks passed
@brentyi brentyi deleted the brent/pydantic_v1_runtime_annotations branch October 24, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behavior of "Optional[T]" and "Suppress"
1 participant