Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch underscore prefix edge case #78

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

brentyi
Copy link
Owner

@brentyi brentyi commented Oct 5, 2023

There were some underscores that were inconsistently being replaced by hyphens!

Includes a test from #77

@brentyi brentyi enabled auto-merge (squash) October 5, 2023 14:46
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a8c6f7) 99.14% compared to head (b773b90) 99.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files          23       23           
  Lines        1996     1996           
=======================================
  Hits         1979     1979           
  Misses         17       17           
Flag Coverage Δ
unittests 99.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tyro/_calling.py 100.00% <ø> (ø)
tyro/_strings.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentyi brentyi merged commit 86a6943 into main Oct 5, 2023
10 checks passed
@brentyi brentyi deleted the brent/patch_underscore branch October 5, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant