Numpy 2 compatibility #1484
Merged
Numpy 2 compatibility #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython 0.29.21 is the oldest version that comes with wheels for Python 3.9
All good – only the Cython dependency needed an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few issues for compatibility with the upcoming (backwards-compatibililty breaking) 2.0 version of numpy. It also switches off the GSL tests for now – GSL is broken on C++ standalone for unrelated reasons (and by chance/bad luck, the way it broke made it skip the tests so I only realized recently…).
I still need to check whether any of the changes requires us to update our minimum version requirement for numpy, but I don't think it is.