Numpy2 compatibility (brian2.units) #1506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes for to make the unit system compatible with the upcoming numpy 2.0 release. It might make sense to revisit this more fundamentally at a later point, but for now the main change is that
__array_wrap__
and__array_prepare__
are merged into__array_ufunc__
. Without doing anything further, this actually enables some new functionality like:Before:
After:
But I don't think many users do complex calculations with
Quantity
arrays in the first place. Still, we need to point this out clearly in the release notes, it might break some code. As discussed, the changes in numpy's system also lead to things likex**(2*volt)
no longer raising an error, sincefloat(2*volt) == 2.0
and this makes things go through thesquare
instead of thepow
ufunc.