Check for multiple synapses #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s found during Brian2->GeNN conversion
mstimberg
force-pushed
the
check_for_multiple_synapses
branch
from
72012bc
to
bc523d6
Compare
…or code to raise a NotImplementedError on the Python side Also change tabs to spaces in convert_synapses.h
mstimberg
force-pushed
the
check_for_multiple_synapses
branch
from
bc523d6
to
34e2b58
Compare
|
hum ... what happened to the tests? |
The test failures where due to other problems not related to the changes in the branch. They were already fixed in master, so after merging master into this branch, all tests now pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #10, Brian2GeNN does not correctly handle multiple connections between a pair of neurons (which is a limitation of GeNN itself, I think?). There's no very clean solution to handle this case, since we don't now whether there are any multisynapses until we have generated them all. The approach in this PR is to check during the conversion of "Brian synapses" to "GeNN synapses". To give a useful error message on the Python level, the code will not only print out an error message but will also exit with a custom error level that is then processed on the Python side and raises a
NotImplementedError.Not sure whether you are happy with my check for multiple synapses, though. Performance-wise it should not have a noticeable effect, I think.