Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suspend MS Edge Browser Support #83

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Suspend MS Edge Browser Support #83

merged 2 commits into from
Dec 28, 2023

Conversation

brianjbayer
Copy link
Owner

@brianjbayer brianjbayer commented Dec 28, 2023

What

This changeset suspends official project support for the Microsoft Edge browser. It is unfortunate that some companies are more interested in selling a product instead of making a product worth selling.

Things may change in the future, so I am commenting out the support instead of fully removing it. It may also be of use as a potential reference.

In addition, this changeset addresses a bug where double brackets ([[ ... ]]) were used instead of single brackets ([ ... ]) in the dockercomposerun script which is shell and not bash.

Why

Support for MS Edge is being suspended due to...

  1. Its user-experience disruptive Personalize your web experience popup which would require browser-specific customization
  2. This Selenium issue which seems to be triggered in the CI Run
  3. Unable to run the selenium-standalone-edge browser image on Apple Silicon

I added MS Edge support as a nice to have but as seems to be common with Microsoft, we can not have nice things.

Change Impact Analysis and Testing

  • CI Checks vet no regressions
  • Inspection of CI Checks output verifies CI is not using MS Edge and fix of single brackets
  • Successful execution and inspection of output of native (Apple Silicon) run of dockercomposerun ensures fix of single brackets results in no regressions
  • Manual inspection of rendered README on this branch verifies documentation update

@brianjbayer brianjbayer marked this pull request as ready for review December 28, 2023 16:13
@brianjbayer brianjbayer merged commit 1ddd61e into main Dec 28, 2023
10 checks passed
@brianjbayer brianjbayer deleted the disable-edge-support branch December 28, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant