You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although I got the tests to "pass", it turns out that it's not working properly.
I haven't been able to completely figure out why yet, but it seems like is_dir() is always returning True and that means in our tests we end up testing nothing
In #35 I got the tests working for Python 3.10 and 3.11.
This introduced some branching code in the definition of a
MockArtifactoryPath
class due to changes in pathlib (the underlying base class):galactory/tests/unit/conftest.py
Lines 86 to 93 in 2b3be89
Although I got the tests to "pass", it turns out that it's not working properly.
I haven't been able to completely figure out why yet, but it seems like
is_dir()
is always returningTrue
and that means in our tests we end up testing nothinggalactory/tests/unit/conftest.py
Line 103 in 2b3be89
Galactory still works fine with Python 3.10 and 3.11 and I expect that will continue, but means there's even less testing than I thought 😞
I've still not made enough headway on #21 , I really need to step up testing in this project.
The text was updated successfully, but these errors were encountered: