Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for collections with no stable / final releases #88

Merged
merged 7 commits into from
Sep 29, 2023

Conversation

briantist
Copy link
Owner

Fixes #87

@briantist briantist added the bug Something isn't working label Sep 28, 2023
@briantist briantist self-assigned this Sep 28, 2023
@briantist briantist added this to the v0.11.0 milestone Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2b3be89) 55.06% compared to head (a79414e) 56.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   55.06%   56.77%   +1.70%     
==========================================
  Files          26       27       +1     
  Lines         977     1011      +34     
==========================================
+ Hits          538      574      +36     
+ Misses        439      437       -2     
Files Coverage Δ
galactory/utilities.py 44.87% <100.00%> (+1.64%) ⬆️
tests/unit/utilities/test_collected_collections.py 100.00% <100.00%> (ø)
tests/unit/utilities/test_discover_collections.py 100.00% <100.00%> (ø)
tests/unit/utilities/test_utilities.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briantist briantist modified the milestones: v0.11.0, v0.10.1 Sep 28, 2023
@briantist
Copy link
Owner Author

I'm glad I introduced a failing test for the issue before starting the fix. The lack of failure in Python 3.10 and 3.11 led to #90

@briantist briantist marked this pull request as ready for review September 29, 2023 21:10
@briantist briantist merged commit 1bd9704 into main Sep 29, 2023
11 checks passed
@briantist briantist deleted the prerelease-latest branch September 29, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error on collections/{namespace}/{collection} when a collection only contains pre-release versions
1 participant