-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace manifest loading from Artifactory #16
Conversation
fcf65d4
to
fee06ab
Compare
@felipempda there's no new release yet (I might create one within the next week or so), but if you're using the container you can pull the |
Hahah thank YOU! I will be using it shortly probably in a WSGI server. Have a good day ;) |
@felipempda do you have any public examples of using it with a WSGI server? Or do you have a preferred one? Even though Flask's server is not meant for production use, I've been fine with it so far, but I haven't tried using it with a full WSGI server yet and I would like to. I'm also considering whether it makes sense to publish additional containers using a specific WSGI server that are maybe more production ready. |
I know of puppetboard: https://github.com/voxpupuli/puppetboard |
Thanks, I will do some research on this over the coming months (might be more in the new year since Q4 is a very busy time), and see how that ight be made easier. I'll consult some other Flask-based projects and some colleagues who are more familiar with this kind of thing. Maybe the project can include a sort of library of integrations with different WSGI servers (or maybe that's an anti-pattern, will find out!). |
Closes #5
This is still a WIP, some things to clean up, and I want to generalize the upload code that's mostly duplicated between direct uploads and uploads-on-proxied-downloads.Completely replaces the loading of the manifest from artifactory's archive file extraction.
Instead we
borrowedstole the parsing from amanda (sivel/amanda@ca3f59f), and we now take the manifest out of the collection archive itself while it's local.This solves two things for us:
collection_info
property before reading into the archive; before that change my downloads were in the 5 or 6 figures, because every iteration was triggering a "download". But this PR will reduce the last of those phantom downloads.This PR will probably supersede #15 , but big thanks to @felipempda for posting that which pushed me to revisit this!