fix incorrect aws schema load, add benchmark for schema load

bridgecrewio · Jul 25, 2023 · f301551 · f301551
1 parent 63944d5
commit f301551
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/terraform/structure/tf_taggable.go b/src/terraform/structure/tf_taggable.go
@@ -19,7 +19,11 @@ import (
 var TfTaggableResourceTypes []string
 
 func init() {
-	linq.From(previousTaggableTypes(awsv4.Resources, isTaggableType, awsv2.Resources, awsv3.Resources, awsv4.Resources)).
+	loadSchema()
+}
+
+func loadSchema() {
+	linq.From(previousTaggableTypes(awsv5.Resources, isTaggableType, awsv2.Resources, awsv3.Resources, awsv4.Resources)).
 		Concat(linq.From(previousTaggableTypes(azurev3.Resources, isTaggableType, azurev2.Resources))).
 		Concat(linq.From(previousTaggableTypes(googlev4.Resources, isGoogleTaggableType, googlev2.Resources, googlev3.Resources))).
 		Concat(linq.From(taggableTypes(awsv5.Resources, isTaggableType))).

diff --git a/src/terraform/structure/tf_taggable_test.go b/src/terraform/structure/tf_taggable_test.go
@@ -91,3 +91,11 @@ func TestKnownUntaggableResourcesShouldNotBeTaggable(t *testing.T) {
 		}
 	}
 }
+
+func BenchmarkInit(b *testing.B) {
+	loadSchema()
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		loadSchema()
+	}
+}