-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yor Doesn't Pick Up Tags When Resource Field Removed In Terraform #377
Comments
This is an interesting one. Yor bases itself on running git blame, and for something that disappears... Yes I see the issue. The relevant function: |
@nimrodkor any idea what would be the fix for the above issue? We are experiencing the similar problem. What logic should be used here to record the resource-level changes (deleted lines)? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Commenting to keep this open as its still an issue. I see there is a PR open for it! #409 |
@J-Scriv-Oblak I've just merged the fix PR, please let me know in case of an issue. |
Describe the bug
Yor will not pick up that a resource was updated if you remove one of its fields.
To Reproduce
Expected behavior
The expected behavior is that your would change the git_commit_id since the resource has been changed. It does not though
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: