Tag resource with remove changes #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanochShayner
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
had a problem deploying
to
scan-security
GitHub Actions
Failure
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
gruebel
reviewed
Jul 18, 2023
rotemavni
reviewed
Jul 18, 2023
There was a problem hiding this comment.
@ChanochShayner would be great to see a test / add to the description of this PR what this change does 🙏
omryMen
reviewed
Jul 18, 2023
ChanochShayner
had a problem deploying
to
scan-security
GitHub Actions
Failure
rotemavni
approved these changes
Jul 18, 2023
ChanochShayner
temporarily deployed
to
scan-security
GitHub Actions
Inactive
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Changes in this PR -
This PR came to solve the issue that we are not identifying the change when we are just removing code from the resources,
By adding a check of -
previous-commit-lines>current-commit-lines.fixes: #377