Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit user info admin service #2631

Merged
merged 49 commits into from
Jul 28, 2023
Merged

Edit user info admin service #2631

merged 49 commits into from
Jul 28, 2023

Conversation

denniscunningham
Copy link
Contributor

PEPPER-973
PEPPER-974
PEPPER-975

This PR implements editing user information but also includes improvements to adding and removing users.
It also implements creating and deleting UserSettings as part of adding and removing users.
And it also implements consistent use of the access_user.is_active flag. More info here.

Checklist

  • I have labeled the type of changes involved using the C-* labels.
  • I have assessed potential risks and labeled using the R-* labels.
  • I have considered error handling and alerts, and added L-* labels as needed.
  • I have considered security and privacy, and added I-* labels as needed
  • I have analyzed my changes for stability, fault tolerance, graceful degradation, performance bottlenecks and written a brief summary in this PR.
  • If applicable, I have discussed the analytics needs at both a platform and study level with Product and instrumented code accordingly.
  • If applicable, my UI/UX changes have passed muster with Product/Design via an over-the-shoulder review, screenshots, etc.

If unsure or need help with any of the above items, add the help wanted label. For items that starts with If applicable, if it is not applicable, check it off and add n/a in front.

FUD Score

Overall, how are you feeling about these changes?

  • ☺️ All good, business as usual!
  • 😅 There might be some issues here
  • 😱 I'm sweaty and nervous

How do we demo these changes?

How does one observe these changes in a deployed system? Note that user visible encompasses many personas--not just patients and study staff, but also ops duty, your fellow devs, compliance, etc.

  • They are user-visible in dev as a regular user journey and require no additional instructions.
  • Getting dev into a state where this is user-visible requires some tech fiddling. I have documented these steps in the related ticket.
  • Requires other features before it's human visible. I have documented the blocking issues in jira.
  • I have no idea how to demo this. Please help me!

Testing

  • I have written automated positive tests
  • I have written automated negative tests
  • I have written zero automated tests but have poked around locally to verify proper functionality
  • The jira ticket has acceptance criteria and QA has the needed information to test changes

Release

  • These changes require no special release procedures--just code!
  • Releasing these changes requires special handling and I have documented the special procedures in the release plan document

@denniscunningham denniscunningham added C-feature Category: non-breaking change which adds new functionality java Pull requests that update Java code dsm DDP Study Manager labels Jul 26, 2023
Copy link
Contributor Author

@denniscunningham denniscunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssettipalli Thx for your review.
Left responses to your comments. Pls let me know how you want to proceed.

Copy link
Contributor Author

@denniscunningham denniscunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssettipalli Thx for your review.
Let me know how you want to proceed. Feel free to DM me if I am not understanding your concerns.

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denniscunningham denniscunningham merged commit 83796ab into develop Jul 28, 2023
5 checks passed
@denniscunningham denniscunningham deleted the pepper-973 branch July 28, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: non-breaking change which adds new functionality dsm DDP Study Manager java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants