-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit user info admin service #2631
Conversation
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dao/user/UserDao.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dao/user/UserDao.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dto/user/UserDto.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/service/admin/UserInfo.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssettipalli Thx for your review.
Left responses to your comments. Pls let me know how you want to proceed.
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dao/user/UserDao.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dao/user/UserDao.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dto/user/UserDto.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/service/admin/UserInfo.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssettipalli Thx for your review.
Let me know how you want to proceed. Feel free to DM me if I am not understanding your concerns.
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dao/user/UserDao.java
Show resolved
Hide resolved
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/db/dto/user/UserDto.java
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
PEPPER-973
PEPPER-974
PEPPER-975
This PR implements editing user information but also includes improvements to adding and removing users.
It also implements creating and deleting UserSettings as part of adding and removing users.
And it also implements consistent use of the access_user.is_active flag. More info here.
Checklist
C-*
labels.R-*
labels.L-*
labels as needed.I-*
labels as neededIf unsure or need help with any of the above items, add the
help wanted
label. For items that starts withIf applicable
, if it is not applicable, check it off and addn/a
in front.FUD Score
Overall, how are you feeling about these changes?
How do we demo these changes?
How does one observe these changes in a deployed system? Note that user visible encompasses many personas--not just patients and study staff, but also ops duty, your fellow devs, compliance, etc.
Testing
Release