PEPPER-1413 delay the shutdown to give the db more time #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ections ahead of starting up replacement instance.
zyme
commented
May 28, 2024
| @@ -78,7 +78,7 @@ public static void startSparkServer(AppEngineShutdown stopRouteCallback, Config | |||
| // as a failure | |||
| if (numShutdownAttempts == 0) { | |||
| final ScheduledThreadPoolExecutor executor = new ScheduledThreadPoolExecutor(1); | |||
| executor.schedule(() -> stopRouteCallback.onAhStop(), 500, TimeUnit.MILLISECONDS); | |||
| executor.schedule(() -> stopRouteCallback.onAhStop(), 5, TimeUnit.SECONDS); | |||
There was a problem hiding this comment.
Going from half a second to 5 seconds.
pegahtah
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEPPER-1413 Quick experiment: delay the shutdown to give the db more time to clear connections ahead of starting up replacement instance. At present, dsm test is starting up, but spark fails to initialize and reports that it's not possible to create a database connection.
One hypothesis is that because ah/stop now returns almost immediately, that a subsequent instance starting up attempts to create a connection pool before the shutting down instance fully releases its connections. This PR is an experiment to gather more information about the timing.
Note that this PR merges into the test branch, not
develop, so that we can try things out in the test environment.