-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSM] PEPPER-1408 Fix for Tracking Scan Duplicate Error #2881
Conversation
@@ -450,6 +450,7 @@ private int deleteKitRequest(Connection conn, int kitRequestId) throws SQLExcept | |||
} | |||
} | |||
|
|||
@VisibleForTesting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this annotation on a public method on a dao. It's general purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, will remove it!
@@ -168,16 +168,6 @@ portal { | |||
and deactivated_date is null | |||
""" | |||
|
|||
insertKitTrackingRequest:""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes Sorry I meant to but forgot to put a comment about it, it is never used and also was throwing me off for more than 15 minutes of why is there an insert statement, so I thought better to remove this unused code.
Context
The error was being thrown because after checking if the value exists the method still tried to insert the values and would get an exception. Fixed it and added a test
Checklist
C-*
labels.R-*
labels.L-*
labels as needed.I-*
labels as neededIf unsure or need help with any of the above items, add the
help wanted
label. For items that starts withIf applicable
, if it is not applicable, check it off and addn/a
in front.FUD Score
Overall, how are you feeling about these changes?
How do we demo these changes?
How does one observe these changes in a deployed system? Note that user visible encompasses many personas--not just patients and study staff, but also ops duty, your fellow devs, compliance, etc.
Testing
Release