Pepper 1040 unable obtain tissue fix #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 20, 2024 11:57
…ue is checked/set to true
…ue is checked/set to true
…ue is checked/set to true
ssettipalli
commented
Aug 21, 2024
| nameValues.add(setAdditionalValue("oD.request", | ||
| new Patch(patch.getId(), PARTICIPANT_ID, patch.getParentId(), patch.getUser(), patch.getNameValue(), | ||
| patch.getNameValues(), patch.getDdpParticipantId()), "sent")); | ||
| patch.getNameValues(), patch.getDdpParticipantId()), OncHistoryDetail.UNABLE_OBTAIN_TISSUE)); |
There was a problem hiding this comment.
set the request : status/value when the "unable to obtain tissue" checkbox is checked/true
ssettipalli
commented
Aug 21, 2024
| @@ -11,7 +16,9 @@ public OncHistoryDetailUnableObtainTissueStrategy(GeneratorPayload generatorPayl | |||
| @Override | |||
| public Map<String, Object> generate() { | |||
| if (isUnableToObtain()) { | |||
| return Map.of(); | |||
| Map<String, Object> resultMap = new HashMap<>(); | |||
There was a problem hiding this comment.
to update in elastic
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/model/patch/BasePatch.java
Outdated
Show resolved
Hide resolved
denniscunningham
approved these changes
Aug 22, 2024
pepper-apis/dsm-core/src/main/java/org/broadinstitute/dsm/model/patch/BasePatch.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEPPER-1040
set the tissue request : status/value to "UnableToObtain" when the "unable to obtain tissue" checkbox is checked/true