PEPPER-923 Restrict onchistory upload for exited participants #2948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniscunningham
requested changes
Nov 6, 2024
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
ssettipalli
commented
Nov 7, 2024
| @@ -0,0 +1,4 @@ | |||
| RECORD_ID FACILITY_PATH_REVIEW FACILITY_PX ACCESSION DATE_PX TYPE_PX LOCATION_PX HISTOLOGY TUMOR_SIZE VIABLE_TUMOR NECROSIS TX_EFFECT BLOCKS_TO_REQUEST SLIDES_TO_REQUEST SLIDES_TOTAL REQUEST_STATUS | |||
| xyz-exit my place 4 3/15/2005 Office 5cm x 6cm x 1cm 100 50 abc "a,b" review | |||
There was a problem hiding this comment.
used this ptp as EXITED ptp and mocked data accordingly for testing
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
denniscunningham
requested changes
Nov 7, 2024
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/ESParticipantIdProvider.java
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/ESParticipantIdProvider.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/ESParticipantIdProvider.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/ESParticipantIdProvider.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
...sm-core/src/main/java/org/broadinstitute/dsm/service/onchistory/OncHistoryUploadService.java
Outdated
Show resolved
Hide resolved
denniscunningham
approved these changes
Nov 7, 2024
|
Thank you Dennis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEPPER-923
During the onc history upload, verify if any of the participants are exited/withdrawn and error out.
Error out whole file upload.