Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AJ-522] add support for empty outputs in orch passthrough #1054

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

jordansafer
Copy link
Contributor

Add the new ignoreEmptyOutputs optional param to the orch passthrough API for creating submissions. This defaults to false, matching the Rawls swagger definition.

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the RC_XXX release ticket with any manual steps required to release this change
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge; you can delete your branch after this unless it's for a hotfix. In that case, don't delete it!
  • Test this change deployed correctly and works on dev environment after deployment

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@jordansafer jordansafer marked this pull request as ready for review October 26, 2022 16:06
@davidangb davidangb merged commit 0444c0e into develop Sep 27, 2023
5 checks passed
@davidangb davidangb deleted the aj-522-ignore-empty-outputs branch September 27, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants