CORE-123: new file-pairing API for data uploader #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
changed the title
kevinmarete
approved these changes
Nov 4, 2024
src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpGoogleServicesDAO.scala
Show resolved
Hide resolved
dvoet
approved these changes
Nov 4, 2024
| val fileList: List[GcsObjectName] = | ||
| googleServicesDao.listBucket(workspaceBucket, Option(matchingOptions.prefix), recursive) | ||
|
|
||
| logger.info(s"found ${fileList.length} files") |
There was a problem hiding this comment.
do we want to place a limit on this based on the number of files returned?
dvoet
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new API at
This API will:
The driver use case for this API is the "Data Uploader" in Terra UI, though we may find that scripters/notebook users also want to use the API.
I have tested this running locally against ~100,000 files in a bucket, and the file-matching portion of the algorithm executes in < 2 seconds. The end result is a 30MB TSV so the API is slow overall, but the size is unavoidable at that scale.