Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-131 Get emails from sam instead of thurloe #1476

Merged
merged 3 commits into from
Oct 31, 2024
Merged

CORE-131 Get emails from sam instead of thurloe #1476

merged 3 commits into from
Oct 31, 2024

Conversation

dvoet
Copy link
Contributor

@dvoet dvoet commented Oct 31, 2024

https://broadworkbench.atlassian.net/browse/CORE-131

Have you read CONTRIBUTING.md lately? If not, do that first.

I, the developer opening this PR, do solemnly pinky swear that:

  • I've followed the instructions if I've made any changes to the API, especially if they're breaking changes
  • I've updated the FISMA documentation if I've made any security-related changes, including auth, encryption, or auditing

In all cases:

  • Get two thumbsworth of review and PO signoff if necessary
  • Verify all tests go green
  • Squash and merge. Make sure your branch deletes; GitHub should do this for you.
  • Test this change deployed correctly and works on dev environment after deployment

@dvoet dvoet requested review from a team, samanehsan and trholdridge and removed request for a team October 31, 2024 18:00
dvoet
dvoet commented Oct 31, 2024
View reviewed changes
src/test/scala/org/broadinstitute/dsde/firecloud/webservice/NihApiServiceSpec.scala
Comment on lines -291 to -296
assertSameElements(Set(services.thurloeDao.TCGA_AND_TARGET_LINKED, services.thurloeDao.TCGA_LINKED),
services.samDao.groups(tcgaDbGaPAuthorized).map(_.value)
)
assertSameElements(Set(services.thurloeDao.TCGA_AND_TARGET_LINKED, services.thurloeDao.TARGET_LINKED),
services.samDao.groups(targetDbGaPAuthorized).map(_.value)
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these checks and the on below because they only test that we have our mocks setup correctly which is not useful. The underlying function is well tested in unit tests.

@dvoet dvoet merged commit 15c80c4 into develop Oct 31, 2024
13 checks passed
@dvoet dvoet deleted the get_emails_from_sam branch October 31, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trholdridge trholdridge trholdridge approved these changes

@samanehsan samanehsan samanehsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvoet @samanehsan @trholdridge