Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD-2758: Add Slide-tags docker #143

Merged
merged 32 commits into from
Oct 17, 2024
Merged

PD-2758: Add Slide-tags docker #143

merged 32 commits into from
Oct 17, 2024

Conversation

aawdeh
Copy link
Contributor

@aawdeh aawdeh commented Oct 4, 2024

Slide-tags Dockerfile taken from https://github.com/MacoskoLab/Macosko-Pipelines/blob/main/positioning/Dockerfile

Modified slightly to reduce the number of layers, etc

@aawdeh aawdeh changed the title PD-2758: Add Slide-tags docker to our list of dockers PD-2758: Add Slide-tags docker Oct 9, 2024
Copy link
Contributor

@ekiernan ekiernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just a suggestion on the label for the docker based on our recent warp-tools one

3rd-party-tools/slide-tags/spatial-count.jl Outdated Show resolved Hide resolved
3rd-party-tools/slide-tags/spatial-count.jl Outdated Show resolved Hide resolved
@aawdeh aawdeh merged commit f4ab579 into develop Oct 17, 2024
14 of 22 checks passed
@aawdeh
Copy link
Contributor Author

aawdeh commented Oct 17, 2024

Created new ticket to deal with the Trivy errors in the PR

@aawdeh aawdeh deleted the aa-slidetag branch October 17, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants