Feat: Added Import Order to Prettier Config #11
Conversation
anna-murphy
added
enhancement
I think it moves third party stuff to the top and leaves the rest?
|
There was a problem hiding this comment.
Do you think we should have a default import order? We have one already in the eslint file, I think maybe the default should match eslint?
Are you hating the import order thing? I'm finding it kinda weird personally. When I include @alias imports in my code it treats them as third party, which is annoying
Can you add a bit to the readme about how this thing should be used?
| "devDependencies": { | ||
| "@trivago/prettier-plugin-sort-imports": "^4.2.0" |
There was a problem hiding this comment.
I think this should be a peer dependency?
| importOrder: [], // Override this for your repo. https://github.com/trivago/prettier-plugin-sort-imports | ||
| importOrderSeparation: true, | ||
| importOrderSortSpecifiers: true, | ||
| plugins: ["@trivago/prettier-plugin-sort-imports"], |
There was a problem hiding this comment.
Can you add a little to the readme about how to override the import order?
|
FWIW we use eslint to enforce the import order in XMA portal? |
Added import order prettier plugin ( https://github.com/trivago/prettier-plugin-sort-imports ). I think this should do nothing unless you override the default order in your prettier config a la the README.
Thoughts?