Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pri[VI]teer - vim + ctags config #1150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pri[VI]teer - vim + ctags config #1150

wants to merge 2 commits into from

Conversation

rachitnigam
Copy link
Member

From the heretical lands where the church of emacs does not exist, I bring to you, VIM:

  • Significantly enhance vim highlighting support for .arr files. Automatic detection for .arr files.
  • Code snippets insertion for common code blocks.
  • ctags support for jumping to function / type definitions and imports.

@rachitnigam rachitnigam self-assigned this Aug 31, 2017
@blerner
Copy link
Member

blerner commented Sep 1, 2017

I don't know of any of us are capable of reviewing this particular PR for you... 😎

@rachitnigam
Copy link
Member Author

@blerner Fixed the issues you pointed out.

@ds26gte
Copy link
Contributor

ds26gte commented Sep 3, 2017

Curious what the addition of the two comment lines (the only change) to indent/pyret.vim is for. It seems to merely identify the original location of the file as itself; why? (And none of the other files have this kind of self-reference.)

@rachitnigam
Copy link
Member Author

@ds26gte that's because I had a separate repo where I was pushing all this code: https://github.com/rachitnigam/pyret-lang.vim

Keeping it in a separate repo helps with vim plugin managers that can directly update the plugin.

I didn't think this repo would want that repo as a submoodule so I moved the latest code here.

@ds26gte
Copy link
Contributor

ds26gte commented Sep 3, 2017

Ah. Sounds good. And since you seem to be way more versed in VimL than I, please do feel free to improve indent/pyret.vim at your convenience: it was a very naive effort on my part and isn't comprehensive.

@jpolitz
Copy link
Member

jpolitz commented Sep 6, 2017

I've had this on for a week now. Is there any reason it could cause searching to become SLOW? Like 10-20 seconds lag when I press enter after a search like /<<<<<?

@rachitnigam
Copy link
Member Author

I haven't noticed a slowdown compared to JS Files of similar sizes. It's pretty lightweight for a syntax highlughter (most of it is just color coding keywords)

@jpolitz
Copy link
Member

jpolitz commented Apr 8, 2018

I still see extreme slowdowns with this in terminal vim on OSX with iterm2, bad enough that I can't navigate around files over a few 100s of lines reasonably. Interestingly, the same doesn't happen in GUI mode Macvim.

@rachitnigam
Copy link
Member Author

That's curious. I haven't had problems with the newest neovim and vim versions either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants