Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow an addtional image caption #269

Closed
wants to merge 3 commits into from

Conversation

splitbrain
Copy link
Contributor

The attribute for title and caption are now configurable via the option array. A caption is usful to give an additional image description or provide proper attribution. This includes the XSS fix from #268

When image titles contain tags, they should not be echoed to the
lightbox title.
The attribute for title and caption are now configurable via the option
array. A caption is usful to give an additional image description or
provide proper attribution. This includes the XSS fix from brutaldesign#268
@splitbrain
Copy link
Contributor Author

The demo has been adjusted to easily try it.

@brutaldesign
Copy link
Owner

Hi,

Seems .useful
But I can't merge your PR now, can you please resubmit from the actual version?

Cheers

* master:
  fixed typo in doc
  minified last version
  minified last version
  remove extra spaces
  ensure that afterMedia fires after media is loaded
  add afterMedia setting to fire function after slide is created
  update README and index page for explaining removeBarsOnMobile option
  adding index parameter to callback functions
  Update README
  Allow the selector to be executed every time, so that if new elements have been inserted in the DOM, they are also included
  Updated readme.md
@splitbrain
Copy link
Contributor Author

I merged the current master and fixed the (minor) conflict.

@jjnxpct
Copy link

jjnxpct commented Aug 3, 2017

Hi! I was looking for the option to add the title or alt of the image to the pop-up image. I guess this PR makers this possible? I am just not sure wat 'PR' is and if this is already included in the current version of the plugin or do I have to download a different version somehow? Or do I need to change files manually?

What I would likt to do is use the alt or title tag of the 'original' image / thumbnail as a caption on the popup version. Can this be done?

Thanks!

Kind regards,
Jip

@maxim-kukushkin
Copy link

Hi! I was looking so much for this simple feature. Sometimes family photos can have extra multi-line comments, which would be awesome to show in the bar. It's a shame that this PR could never be merged.
I have very limited version of JS, but may be I'll try to redo the code changes with the latest version. Just can't guarantee that I'll succeed with it

@maxim-kukushkin
Copy link

Raised a new PR, replicating the changes there: #392

@splitbrain splitbrain closed this Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants