-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow an addtional image caption #269
Conversation
When image titles contain tags, they should not be echoed to the lightbox title.
The attribute for title and caption are now configurable via the option array. A caption is usful to give an additional image description or provide proper attribution. This includes the XSS fix from brutaldesign#268
The demo has been adjusted to easily try it. |
Hi, Seems .useful Cheers |
* master: fixed typo in doc minified last version minified last version remove extra spaces ensure that afterMedia fires after media is loaded add afterMedia setting to fire function after slide is created update README and index page for explaining removeBarsOnMobile option adding index parameter to callback functions Update README Allow the selector to be executed every time, so that if new elements have been inserted in the DOM, they are also included Updated readme.md
I merged the current master and fixed the (minor) conflict. |
Hi! I was looking for the option to add the title or alt of the image to the pop-up image. I guess this PR makers this possible? I am just not sure wat 'PR' is and if this is already included in the current version of the plugin or do I have to download a different version somehow? Or do I need to change files manually? What I would likt to do is use the alt or title tag of the 'original' image / thumbnail as a caption on the popup version. Can this be done? Thanks! Kind regards, |
Hi! I was looking so much for this simple feature. Sometimes family photos can have extra multi-line comments, which would be awesome to show in the bar. It's a shame that this PR could never be merged. |
Raised a new PR, replicating the changes there: #392 |
The attribute for title and caption are now configurable via the option array. A caption is usful to give an additional image description or provide proper attribution. This includes the XSS fix from #268