adding in compatibility to work with disthene-reader #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default variables for the ability to use this finder with the disthene-reader project.
After much time working to get cyanite running well along with graphite-api, it was apparent that the poor performance of the cyanite processes interaction with the metric path index being stored within cassandra was not going to be feasible for our environment (due to volume and variety of metric name spaces, the jvm spent all its time in cpu regardless of heap sizing).
This started us looking towards the disthene project, and since it supported the use of elasticsearch (as did cyanite prior to 0.5.1 iirc) this proved to be very quick and fit our use case.
However disthene additionally has a notion of multi tenancy, and to support being able to query its mostly cyanite compatible api, i've added this value to the graphite-cyanite finder with some sane defaults that should ensure compatibility.