Adds Batch client connection and async RPC calls to the bitcoind client #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
guggero
reviewed
Aug 19, 2022
Vib-UX
force-pushed
the
BatchClient
branch
2 times, most recently
from
759043b
to
7f29aa8
Compare
Thanks for the insightful review @guggero, I have updated the commits accordingly. |
|
@Vib-UX Just FYI: I'm waiting with my next round of review since some of the changes requested in the |
guggero
reviewed
Nov 17, 2022
Recently solved a few test-coverage issues while implementing generic functions, and will be pushing updates by this weekend, had a chat with @bhandras as well regarding this. |
This commit adds a batch client connection and async RPC calls to the bitcoind client which will enable batching multiple requests speeding up operations by reducing round trips.
This will leverage the updated batch client to fetch multiple blocks in one go which can speed up rescan and filter blocks.
Both RescanBlocksBatched() and FilterBlocksBatched() leverages GetBlocksBatch() which works with the updated batch client for speed ups.
Testcoverage to ensure that GetBlocksBatch() which leverages batchAPI works as expected with enhanced performance.
Testcoverage to ensure that RescanBlocksBatched() which leverages updated batchAPI for scanning the chain works as expected with enhanced performance.
Testcoverage to ensure that FilterBlocksBatched() which leverages batchAPI for scanning the chain works as expected with enhanced performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR serves in relation to fixing issue 5041
With this PR we enable batch client connection and async RPC calls to the bitcoind client providing testcoverages for the same. This helps us in batching the required requests needed for speeding up operations by reducing round trips.
Speedups:
Pull Request Checklist
Testing
Code Style and Documentation
📝 Please see our Contribution Guidelines for further guidance.