gomod: update go mod using go work sync
#946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Aug 14, 2024
|
Hmm, I think we might need to do this in stages so we can tag new versions of the various sub-modules incrementally. |
yyforyongyu
force-pushed
the
update-gomod
branch
3 times, most recently
from
d5f208d
to
bdef8c4
Compare
yyforyongyu
force-pushed
the
update-gomod
branch
4 times, most recently
from
a2c1215
to
906d381
Compare
guggero
reviewed
Aug 21, 2024
.golangci.yml
Outdated
|
|
||
| issues: | ||
| # Only check issues in the new code. | ||
| new-from-rev: HEAD~1 |
There was a problem hiding this comment.
Wouldn't this cause to only look at code in the very last commit? Shouldn't we pin this to a fixed version and update every once in a while?
There was a problem hiding this comment.
yeah was experimenting sth...basically I was trying to use new-from-rev: master - the idea is to only lint the diff between the current PR and the master, but couldn't get it to work due to this error,
level=warning msg="[runner] Can't process result by diff processor: can't prepare diff by revgrep: could not read git repo: error executing \"git diff --color=never --no-ext-diff --default-prefix --relative master --\": exit status 128: fatal: bad revision 'master'\n"
seems to be a revgrep.go issue.
Changed to commit instead.
|
Oops, I just realized that all my comments should've been in #947... |
|
Can be rebased. Pushed the following tags: |
yyforyongyu
force-pushed
the
update-gomod
branch
from
906d381
to
236e975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync versions across repos.
Depends on