-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates protovalidate, adds support for new ignore semantics. The PR is huge but it's mostly gencode; the actual CEL code wasn't too substantially altered. ~~Unfortunately I could not get the tests to pass 100%. There is a minor wrinkle where, I _believe_, the behavior of `has(x.y)` and `x.y` needs to differ (specifically with proto3 optional) but it can not due to the way the interpreter works. It _seems_ like this only impacts some rather small edge cases so I guess we might be able to live with it in the interim. I've just added said tests to the nonconforming list.~~ **Update:** The issues still exist upstream (assuming the issue is valid and not a mistake on my part) but we are now working around it, and tests now pass 100% (sans the existing failures.) All other tests pass and I _believe_ my fixes are correct. The e-mail check was corrected to not support bracketed emails as was done with the Go version.
- Loading branch information
1 parent
86e4937
commit 4c035d0
Showing
75 changed files
with
4,721 additions
and
1,927 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
version: v1 | ||
plugins: | ||
- plugin: buf.build/protocolbuffers/python:v23.2 | ||
- plugin: buf.build/protocolbuffers/python:v27.2 | ||
out: gen | ||
- plugin: buf.build/protocolbuffers/pyi:v23.2 | ||
- plugin: buf.build/protocolbuffers/pyi:v27.2 | ||
out: gen |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Generated by buf. DO NOT EDIT. | ||
version: v1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.