Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FixtureConfig with an Objective-C version #1695

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kstenerud
Copy link
Contributor

@kstenerud kstenerud commented Sep 26, 2024

Goal

Using a Swift version of FixtureConfig makes objc interop harder because you have to forward declare the class in objc, which makes splitting out certain parts of the interface impossible.

Instead, we just make an objective-c version. It's just a data class, so bridging header interop works fine.

This also splits out the bridging header to have one that accesses internal APIs, and another that only has access to our public API (for XCFramework based testing fixtures).

…easier to split things out in a later PR without causing objc-swift issues.
Copy link

Bugsnag.framework binary size did not change - 656,120 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@kstenerud kstenerud merged commit cb78ff7 into next Sep 27, 2024
44 checks passed
@kstenerud kstenerud deleted the karl/objc-fixture-config branch September 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants