[DTA-1034] Integrate BugSnag error monitoring in the Payment Service #6
Conversation
src/paymentservice/charge.js
Outdated
|
|
||
| module.exports.charge = async request => { | ||
| const span = tracer.startSpan('charge'); | ||
|
|
||
| await OpenFeature.setProviderAndWait(flagProvider); | ||
| if (await OpenFeature.getClient().getBooleanValue("paymentServiceFailure", false)) { | ||
| Bugsnag.notify(new Error("PaymentService Fail Feature Flag Enabled")); |
There was a problem hiding this comment.
Bugsnag by default should report unhandled errors. If you remove this line, does it still send an error?
There was a problem hiding this comment.
I couldn't manage to make it work without it. But having a look into the documentation, I understood that only unhandled exceptions and unhandled promises would be reported, so I assumed that it's the expected behaviour.
docker-compose.yml
Outdated
| @@ -439,6 +439,7 @@ services: | |||
| - "${PAYMENT_SERVICE_PORT}" | |||
| environment: | |||
| - PAYMENT_SERVICE_PORT | |||
| - PAYMENT_SERVICE_BUGSNAG_API_KEY | |||
There was a problem hiding this comment.
Based on how the Terraform configuration looks, it seems that we need to keep the BUGSNAG_API_KEY in the app and add the mapping in here, so what should work is:
- BUGSNAG_API_KEY=${PAYMENT_SERVICE_BUGSNAG_API_KEY}
So in the .env file we will have PAYMENT_SERVICE_BUGSNAG_API_KEY and in the code in the app BUGSNAG_API_KEY.
Please let me know if it works.
There was a problem hiding this comment.
I made the change and it works, I could still see the error in Bugnsag
LucjanMichalowski
deleted the
adolfo/DTA-1034-Bugsnag-error-monitoring
branch
Changes
Installed Bugnsag Error Monitoring into the payment service.
DTA-1034