Skip to content
This repository has been archived by the owner on Mar 25, 2020. It is now read-only.

#23: order pledges by expiry date in /pledge list (closes #23) #24

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

#23: order pledges by expiry date in /pledge list (closes #23) #24

wants to merge 23 commits into from

Conversation

lucacioria
Copy link
Member

@lucacioria lucacioria commented Feb 5, 2017 •
edited
Loading

Issue #23

Test Plan

tests performed

  • added 2 pledges in reverse order, they are now sorted

tests not performed (domain coverage)

@lucacioria
add prefix to list test
316cfe3
@lucacioria
complete create test to test for pledge to be in list too
63e32e4
@lucacioria
adding return to all res.send to avoid UnhandledPromiseRejectionWarning
f26057b
@lucacioria
completed test -> expired: notifies both at the right time, stays in …
60cf66b 
…list
@lucacioria
added test for expired: does not notify for completed pledges, also c…
e3ba4af 
…loses #7
@lucacioria
completed test -> expired: does not notify for deleted pledges
7c84ac2
@lucacioria
completed test -> delete: notifies both immediately, disappears form …
ba35f7c 
…list
@lucacioria
tests for completed pledges
d5081de
@lucacioria
refactor
9787034
@lucacioria
add restart command to package json using nodemon
8cffbcc
@lucacioria
add slack keys to config files
c1ee030
@lucacioria
write migration to schema v4 and add functions for teams
a87df4a
@lucacioria
change slack functions to work with bots instead of incoming webhooks
55e740d
@lucacioria
adapted routes to work with bot and added oauth2
8820d6d
@lucacioria
added route add-to-slack which shows the add to slack button in a bro…
131b51c 
…wser
@lucacioria
yarn lock for all previous changes
7a6ace9
@lucacioria
added pledge and pledge-test icons for slack app
f2d4c97
@lucacioria
remove migrations as impossible to migrate to slack app, and not much…
c166249 
… useful for a single deploy
@lucacioria
make tests pass, fixing tests and a few bugs :)
04b3c9f
@lucacioria
add https
c54b21b
@lucacioria
avoid inserting duplicate teams
1064bf0
@lucacioria
added logic to send notification as bot instead as @slackbot
0742eaa
@lucacioria
added ORDER BY
5b60c1e
@nemobot nemobot added the WIP label Feb 5, 2017
@nemobot nemobot added in review and removed WIP labels Feb 6, 2017
@lucacioria lucacioria requested a review from gabro February 6, 2017 08:49
gabro
gabro suggested changes Feb 7, 2017
View reviewed changes
Copy link
Member

@gabro gabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a small change, but you may want to add a test for it.

@gabro gabro removed their assignment Feb 21, 2017
@gabro
Copy link
Member

gabro commented Feb 21, 2017

@lucacioria re-assign me once you've fixed the changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gabro gabro gabro requested changes

Assignees
No one assigned
Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacioria @gabro @nemobot