Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change how subtle is imported
crypto.subtle
officially points tocrypto.webcrypto.subtle
and makes it easier to alias the"crypto"
module in react-native sincewindow.crypyo.subtle
/globalThis.crypto.subtle
/require("crypto").subtle
all work on the same key path. Tested & confirmed it works.hash: string
instead ofhash: { name: string }
Hash can be passed as a string or as
{ name: string }
, but there is no purpose to the latter.https://github.com/margelo/react-native-quick-crypto/ for React Native only supports the string version (raised issue: margelo/react-native-quick-crypto#557) and that library is the only one which supports SubtleCrypto for RN
So this change is for compatibility with React Native.