Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit #1

Merged
merged 7 commits into from
May 31, 2024
Merged

initial commit #1

merged 7 commits into from
May 31, 2024

Conversation

tifa365
Copy link

@tifa365 tifa365 commented May 20, 2024

No description provided.

tim and others added 7 commits May 20, 2024 12:27
- Corrected the schema definition for GET /searchresults/:
  - Updated results property to be an array instead of a string.
  - Specified application/json as the content type for a successful response.

- Enhanced schema for GET /krankenhaussuche/krankenhaus/{id}/:
  - Added documentation for possible 404 (Not Found) and 503 (Service Unavailable) responses.
  - Updated query parameter types and descriptions for better clarity.

- Ensured schema accuracy and conformance to actual API responses.

This commit addresses the issues identified during Schemathesis testing and aligns the schema with the actual API behavior.
@wirthual
Copy link
Member

Seems like there are some issues in the response description for the searchresult endpoint. However I think we should get the ball rolling and merge this PR and do updates to the schema with additional PRs.

@wirthual wirthual merged commit 18bfc95 into bundesAPI:main May 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants