Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some custom WASI SDK fixes #433

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

jeffcharles
Copy link
Collaborator

Some improvements for custom WASI SDK handling.

  1. Introduce the QUICKJS_WASM_SYS_WASI_SDK_MAJOR_VERSION and QUICKJS_WASM_SYS_WASI_SDK_MINOR_VERSION environment variables for customizing the versions of the WASI SDK to use without having to recompile the build script for quickjs-wasm-sys. This is helpful for quickly experimenting with using different versions of the WASI SDK.
  2. Trigger a recompilation if any of the values for QUICKJS_WASM_SYS_WASI_SDK_PATH, QUICKJS_WASM_SYS_WASI_SDK_MAJOR_VERSION, or QUICKJS_WASM_SYS_WASI_SDK_MINOR_VERSION change. This fixes a bug where changes to the WASI SDK may not have triggered a recompilation as expected.
  3. Remove the Makefile target for download-wasi-sdk and associated shell script. This target and shell script should no longer be necessary given the build script and the new environment variables for quickly experimenting with new SDK versions.

I'm opting to do a minor version bump for quickjs-wasm-sys given the new build time environment variables would technically count as new features I think.

@jeffcharles jeffcharles merged commit d6d9203 into main Jul 13, 2023
7 checks passed
@jeffcharles jeffcharles deleted the jc.quickjs-wasm-sys-build-fixes branch July 13, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants