Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements for custom WASI SDK handling.
QUICKJS_WASM_SYS_WASI_SDK_MAJOR_VERSION
andQUICKJS_WASM_SYS_WASI_SDK_MINOR_VERSION
environment variables for customizing the versions of the WASI SDK to use without having to recompile the build script forquickjs-wasm-sys
. This is helpful for quickly experimenting with using different versions of the WASI SDK.QUICKJS_WASM_SYS_WASI_SDK_PATH
,QUICKJS_WASM_SYS_WASI_SDK_MAJOR_VERSION
, orQUICKJS_WASM_SYS_WASI_SDK_MINOR_VERSION
change. This fixes a bug where changes to the WASI SDK may not have triggered a recompilation as expected.download-wasi-sdk
and associated shell script. This target and shell script should no longer be necessary given the build script and the new environment variables for quickly experimenting with new SDK versions.I'm opting to do a minor version bump for
quickjs-wasm-sys
given the new build time environment variables would technically count as new features I think.