Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return bound endpoints after server started #113

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: return bound endpoints after server started #113

wants to merge 4 commits into from
+88 −42

Commits on May 12, 2023

  1. fix: return bound endpoints after server started 

    The impetus behind the change is to support adding monitoring endpoints with
an optional additional TCP listener. While refactoring the server it was
discovered that the run method moves the Server self, and so fixed bytecodealliance#112 to
also ensure that the API endpoint was running before tests could discover the
listener's locally bound port.

In addition a common cancellation token is added to the server to propagate
shutdown to both the core service as well as the API server endpoint. It can be
later used to support additional services later such as a monitoring
endpoint(s).
    @kriswuollett
    kriswuollett committed May 12, 2023
    Configuration menu
    Copy the full SHA
    eb1767a View commit details
    Browse the repository at this point in the history

  2. docs: fix wording of server methods

    @kriswuollett
    kriswuollett committed May 12, 2023
    Configuration menu
    Copy the full SHA
    41fd3d7 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Apply suggestions from code review 

    docs: fix code comments on server

Co-authored-by: Peter Huene <[email protected]>
Signed-off-by: Kristopher Wuollett <[email protected]>
    @kriswuollett @peterhuene
    kriswuollett and peterhuene authored May 18, 2023
    Configuration menu
    Copy the full SHA
    a46c7f0 View commit details
    Browse the repository at this point in the history

  2. fix: clarify copying of endpoints struct 

    Co-authored-by: Peter Huene <[email protected]>
Signed-off-by: Kristopher Wuollett <[email protected]>
    @kriswuollett @peterhuene
    kriswuollett and peterhuene authored May 18, 2023
    Configuration menu
    Copy the full SHA
    4648e46 View commit details
    Browse the repository at this point in the history