Update missing content API #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
reviewed
Jul 14, 2023
lann
force-pushed
the
update-missing-content
branch
from
3ec6da0
to
9f57c67
Compare
This wraps a url::Url for a couple of purposes: - Asserts the invariant that the Url is a valid warg base URL - Provdies a `::safe_label` method which produces a mangled version of the URL appropriate for e.g. file paths This new type is used in client config and replaces the 'host' string used in keyring management.
lann
force-pushed
the
update-missing-content
branch
from
9f57c67
to
b000eb6
Compare
lann
commented
Jul 24, 2023
lann
commented
Jul 24, 2023
lann
force-pushed
the
update-missing-content
branch
from
b000eb6
to
c4f8640
Compare
lann
commented
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposal here: #160 It adapts some of #137. Notably it does not add a "patch record" operation as I think that conflicts with #146.
I also fell down a bit of a rabbit hole to allow upload URLs to be specified relative to the registry URL which led to a refactor that adds a
RegistryUrltype. Note that this will (probably) break existing client config forlocalhostenvironments as it makes port numbers significant for on-disk paths and the keyring.