Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark test case .wasm with lots of unique fn types #1880

Merged

Conversation

Robbepop
Copy link
Contributor

@Robbepop Robbepop commented Oct 23, 2024

Crafted an example module for this comment: #1701 (comment)
Note: we already had a module with lots of types, but they were all empty function types, so I crafted another module with all unique function types.
The test case has the following form and contains over 5000 unique function types.

cc @alexcrichton

(module
	(type (func (param i32) ))
	(type (func (param i64) ))
	(type (func (param f32) ))
	(type (func (param f64) ))
	(type (func (param i32) (param i32) ))
	(type (func (param i32) (param i64) ))
	(type (func (param i32) (param f32) ))
	(type (func (param i32) (param f64) ))
	(type (func (param i64) (param i32) ))
	(type (func (param i64) (param i64) ))
	(type (func (param i64) (param f32) ))
	(type (func (param i64) (param f64) ))
	(type (func (param f32) (param i32) ))
	(type (func (param f32) (param i64) ))
	(type (func (param f32) (param f32) ))
	(type (func (param f32) (param f64) ))
	(type (func (param f64) (param i32) ))
	(type (func (param f64) (param i64) ))
	(type (func (param f64) (param f32) ))
	(type (func (param f64) (param f64) ))
	(type (func (param i32) (param i32) (param i32) ))
	(type (func (param i32) (param i32) (param i64) ))
	(type (func (param i32) (param i32) (param f32) ))
	(type (func (param i32) (param i32) (param f64) ))
	;; etc..
	(type (func (param f64) (param f64) (param f64) (param f64) (result f32) (result i32) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f32) (result i64) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f32) (result f32) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f32) (result f64) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f64) (result i32) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f64) (result i64) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f64) (result f32) ))
	(type (func (param f64) (param f64) (param f64) (param f64) (result f64) (result f64) ))
)

Running both validation benchmark test cases for lot-of-types:

image

@alexcrichton alexcrichton added this pull request to the merge queue Oct 23, 2024
Merged via the queue into bytecodealliance:main with commit bae057e Oct 23, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants